[Bug 222118] multimedia/handbrake handbrake dumps core when navigating to select source

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222118

--- Comment #22 from heathn at gmail.com ---
(In reply to naito.yuichiro from comment #17)

Handbrake works just fine with the clang compiler.  I've been using my
clang-built Handbrake for some time without issue.  However, I don't use the
i386 arch which is why I wasn't aware of the compiler issue until Vladimir
pointed it out.

I personally prefer to not have to install a 2nd compiler if it isn't
absolutely required but it is not my decision.

You are correct that additional patching of the source would be required to get
it to work on i386 but it seems that additional patching will still be required
to use a more recent version of gcc.

I installed a i386 instance to see what the issue is and it appears that the
build just needs to disable use of the EBX register.  Similar to what can be
found here: https://trac.ffmpeg.org/ticket/4599.  I just haven't found the time
to figure out how best to patch handbrake since its build system is different
from what I'm used to....

Since much of the Handbrake source comes from the ffmpeg project, I looked at
how the multimedia/ffmpeg port works around this issue.  In the file
multimedia/ffmpeg/files/patch-libavutil-x86-asm.h you can see:

-#define HAVE_7REGS (ARCH_X86_64 || (HAVE_EBX_AVAILABLE && HAVE_EBP_AVAILABLE))
+#define HAVE_7REGS (ARCH_X86_64 || (HAVE_EBX_AVAILABLE && HAVE_EBP_AVAILABLE
&&
 !defined(__clang__)))


It seems like such a solution would solve the same compiler problem identified
by Vladimir...(at least if you want to try to use clang as the compiler)

-- 
You are receiving this mail because:
You are the assignee for the bug.