[Bug 223139] New port: games/OpenClaw, reimplementation of Captain Claw (1997) platformer

Wed Oct 25 12:58:32 UTC 2017

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223139

Jan Beich <jbeich at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |greg at unrelenting.technology
                   |                            |, jbeich at FreeBSD.org
 Attachment #187461|                            |maintainer-approval?(greg at u
              Flags|                            |nrelenting.technology)

--- Comment #1 from Jan Beich <jbeich at FreeBSD.org> ---
Created attachment 187461
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=187461&action=edit
simplify

Some bits maybe easier to explain via patch.

> +PORTNAME=		OpenClaw
[...]
> +DATADIR=	${LOCALBASE}/share/openclaw
[...]
> +	${INSTALL} -s ${WRKSRC}/../Build_Release/openclaw \

CamelCase is undesirable for package names. In this case, it seems lower case
is more common. AUR also uses lower case.

> +DISTVERSION=		1.0-29
> +DISTVERSIONSUFFIX=	-g49c28d9
> +CATEGORIES=		games

This can be realigned to match indentation of the rest of the file.

> +USES=		cmake:outsource ...

Why :outsource? It's neither required nor safe per
CMAKE_RUNTIME_OUTPUT_DIRECTORY.

> +do-install:
> +	${INSTALL} -s ${WRKSRC}/../Build_Release/openclaw \
> +			${STAGEDIR}${PREFIX}/bin/openclaw

${INSTALL} -s should be spelled as either ${INSTALL_PROGRAM} or ${INSTALL_LIB}

> +	${INSTALL} ${WRKSRC}/Build_Release/ClawLauncher.exe \
> +			${STAGEDIR}${PREFIX}/bin/ClawLauncher.exe

Use ${INSTALL_DATA} to drop executable bit thus avoid the clutter in shell
command completion.

> +	${SED} -e 's|/usr/share/openclaw|${DATADIR}|g' \
> +		${WRKSRC}/Build_Release/clawlauncher > \
> +		${WRKSRC}/Build_Release/clawlauncher_freebsd
> +	${INSTALL} ${WRKSRC}/Build_Release/clawlauncher_freebsd \
> +			${STAGEDIR}${PREFIX}/bin/clawlauncher

Use ${REINPLACE_CMD}. /usr/local isn't really specific to FreeBSD.

> +	${INSTALL_DATA} ${WRKSRC}/Build_Release/ASSETS.ZIP \
> +			${STAGEDIR}${DATADIR}/ASSETS.ZIP
> +	${INSTALL_DATA} ${WRKSRC}/Build_Release/clacon.ttf \
> +			${STAGEDIR}${DATADIR}/clacon.ttf
> +	${INSTALL_DATA} ${WRKSRC}/Build_Release/console02.tga \
> +			${STAGEDIR}${DATADIR}/console02.tga
> +	${INSTALL_DATA} ${WRKSRC}/Build_Release/SAVES.XML \
> +			${STAGEDIR}${DATADIR}/SAVES.XML

Maybe use COPYTREE_SHARE instead.

> +To complete the installation of this port you need to copy the file
> +"CLAW.REZ" from the original Captain Claw distribution to
> +%%DATADIR%%.

Doesn't seem to work unless clawlauncher was used at least once.

  $ rm -rf ~/.config/openclaw/
  $ openclaw
  INFO: Looking for: /home/luser/.config/openclaw/config.xml
  INFO: Expecting config.xml in path: /home/luser/.config/openclaw/config.xml
  WARN: [LoadGameOptions] Configuration file:
/home/luser/.config/openclaw/config.xml not found - creating default
configuration
  Assertion failed: (ParseValueFromXmlElem(&m_GameOptions.customArchive,
assetsElem->FirstChildElement("CustomArchive"))), function LoadGameOptions,
file OpenClaw/Engine/GameApp/BaseGameApp.cpp, line 429.
  Abort trap

  $ mkdir -p ~/.config/openclaw
  $ (cd /usr/local/share/openclaw/; cp SAVES.XML config.xml
~/.config/openclaw/)
  $ openclaw
  INFO: Looking for: /home/luser/.config/openclaw/config.xml
  INFO: Expecting config.xml in path: /home/luser/.config/openclaw/config.xml
  INFO: Loaded with:
          Config File: /home/luser/.config/openclaw/config.xml
          Saves File: /home/luser/.config/openclaw/SAVES.XML
  INFO: >>>>> Initializing display...
  INFO: Display successfully initialized.
  INFO: >>>>> Initializing audio...
  INFO: Audio successfully initialized.
  INFO: >>>>> Initializing font...
  INFO: Font successfully initialized...
  INFO: >>>>> Initializing resource cache...
  INFO: Resource cache successfully initialized
  INFO: >>>>> Loading actor prototypes...
  INFO: Actor prototypes loaded successfully.
  INFO: 1
  INFO: Changing to: 3

> +To use clawlauncher (optional), install lang/mono.

Looks underspecified.

  $ pkg install mono
  $ clawlauncher
  WARNING: The runtime version supported by this application is unavailable.
  Using default runtime: v4.0.30319

  Unhandled Exception:
  System.TypeInitializationException: The type initializer for
'System.Windows.Forms.XplatUI' threw an exception. --->
System.TypeInitializationException: The type initializer for
'System.Drawing.GDIPlus' threw an exception. ---> System.DllNotFoundException:
libgdiplus.so
    at (wrapper managed-to-native) System.Drawing.GDIPlus:GdiplusStartup
(ulong&,System.Drawing.GdiplusStartupInput&,System.Drawing.GdiplusStartupOutput&)
    at System.Drawing.GDIPlus..cctor () [0x000cc] in
<5eb1d9ccfec943adba5ae843e256d04f>:0
     --- End of inner exception stack trace ---
    at (wrapper managed-to-native)
System.Object:__icall_wrapper_mono_generic_class_init (intptr)
    at System.Drawing.Graphics.FromHdcInternal (System.IntPtr hdc) [0x00000] in
<5eb1d9ccfec943adba5ae843e256d04f>:0
    at System.Windows.Forms.XplatUIX11.SetDisplay (System.IntPtr
display_handle) [0x0007e] in <b4e6df1a5a1f4b78af726adaf5fd3ede>:0
    at System.Windows.Forms.XplatUIX11..ctor () [0x00077] in
<b4e6df1a5a1f4b78af726adaf5fd3ede>:0
    at System.Windows.Forms.XplatUIX11.GetInstance () [0x0001c] in
<b4e6df1a5a1f4b78af726adaf5fd3ede>:0
    at System.Windows.Forms.XplatUI..cctor () [0x0007d] in
<b4e6df1a5a1f4b78af726adaf5fd3ede>:0
     --- End of inner exception stack trace ---
    at System.Windows.Forms.Application.EnableVisualStyles () [0x00006] in
<b4e6df1a5a1f4b78af726adaf5fd3ede>:0
    at ClawLauncher.Program.Main () [0x00030] in
<a4adea8190ba4536856f18624a80285b>:0
  [ERROR] FATAL UNHANDLED EXCEPTION: System.TypeInitializationException: The
type initializer for 'System.Windows.Forms.XplatUI' threw an exception. --->
System.TypeInitializationException: The type initializer for
'System.Drawing.GDIPlus' threw an exception. ---> System.DllNotFoundException:
libgdiplus.so
    at (wrapper managed-to-native) System.Drawing.GDIPlus:GdiplusStartup
(ulong&,System.Drawing.GdiplusStartupInput&,System.Drawing.GdiplusStartupOutput&)
    at System.Drawing.GDIPlus..cctor () [0x000cc] in
<5eb1d9ccfec943adba5ae843e256d04f>:0
     --- End of inner exception stack trace ---
    at (wrapper managed-to-native)
System.Object:__icall_wrapper_mono_generic_class_init (intptr)
    at System.Drawing.Graphics.FromHdcInternal (System.IntPtr hdc) [0x00000] in
<5eb1d9ccfec943adba5ae843e256d04f>:0
    at System.Windows.Forms.XplatUIX11.SetDisplay (System.IntPtr
display_handle) [0x0007e] in <b4e6df1a5a1f4b78af726adaf5fd3ede>:0
    at System.Windows.Forms.XplatUIX11..ctor () [0x00077] in
<b4e6df1a5a1f4b78af726adaf5fd3ede>:0
    at System.Windows.Forms.XplatUIX11.GetInstance () [0x0001c] in
<b4e6df1a5a1f4b78af726adaf5fd3ede>:0
    at System.Windows.Forms.XplatUI..cctor () [0x0007d] in
<b4e6df1a5a1f4b78af726adaf5fd3ede>:0
     --- End of inner exception stack trace ---
    at System.Windows.Forms.Application.EnableVisualStyles () [0x00006] in
<b4e6df1a5a1f4b78af726adaf5fd3ede>:0
    at ClawLauncher.Program.Main () [0x00030] in
<a4adea8190ba4536856f18624a80285b>:0

  $ pkg install libgdiplus
  $ clawlauncher
  WARNING: The runtime version supported by this application is unavailable.
  Using default runtime: v4.0.30319
  Gtk not found (missing LD_LIBRARY_PATH to libgtk-x11-2.0.so.0?), using
built-in colorscheme

  Unhandled Exception:
  System.ArgumentException: The requested FontFamily could not be found [GDI+
status: FontFamilyNotFound]
    at System.Drawing.GDIPlus.CheckStatus (System.Drawing.Status status)
[0x001e5] in <5eb1d9ccfec943adba5ae843e256d04f>:0
    at System.Drawing.FontFamily..ctor (System.Drawing.Text.GenericFontFamilies
genericFamily) [0x0005b] in <5eb1d9ccfec943adba5ae843e256d04f>:0
    at (wrapper remoting-invoke-with-check) System.Drawing.FontFamily:.ctor
(System.Drawing.Text.GenericFontFamilies)
    at System.Drawing.FontFamily.get_GenericSansSerif () [0x00000] in
<5eb1d9ccfec943adba5ae843e256d04f>:0
    at System.Drawing.Font.CreateFont (System.String familyName, System.Single
emSize, System.Drawing.FontStyle style, System.Drawing.GraphicsUnit unit,
System.Byte charSet, System.Boolean isVertical) [0x00014] in
<5eb1d9ccfec943adba5ae843e256d04f>:0
    at System.Drawing.Font..ctor (System.String familyName, System.Single
emSize, System.Drawing.FontStyle style, System.Drawing.GraphicsUnit unit,
System.Byte gdiCharSet, System.Boolean gdiVerticalFont) [0x00011] in
<5eb1d9ccfec943adba5ae843e256d04f>:0
    at System.Drawing.Font..ctor (System.String familyName, System.Single
emSize, System.String systemName) [0x00000] in
<5eb1d9ccfec943adba5ae843e256d04f>:0
    at (wrapper remoting-invoke-with-check) System.Drawing.Font:.ctor
(string,single,string)
    at System.Drawing.SystemFonts.get_DefaultFont () [0x00000] in
<5eb1d9ccfec943adba5ae843e256d04f>:0
    at System.Windows.Forms.Theme.get_DefaultFont () [0x0000d] in
<b4e6df1a5a1f4b78af726adaf5fd3ede>:0
    at System.Windows.Forms.Control.get_DefaultFont () [0x00005] in
<b4e6df1a5a1f4b78af726adaf5fd3ede>:0
    at System.Windows.Forms.Control.get_Font () [0x00031] in
<b4e6df1a5a1f4b78af726adaf5fd3ede>:0
    at System.Windows.Forms.Form..ctor () [0x00018] in
<b4e6df1a5a1f4b78af726adaf5fd3ede>:0
    at ClawLauncher.ClawLauncherForm..ctor () [0x00000] in
<a4adea8190ba4536856f18624a80285b>:0
    at (wrapper remoting-invoke-with-check) ClawLauncher.ClawLauncherForm:.ctor
()
    at ClawLauncher.Program.Main () [0x0003b] in
<a4adea8190ba4536856f18624a80285b>:0
  [ERROR] FATAL UNHANDLED EXCEPTION: System.ArgumentException: The requested
FontFamily could not be found [GDI+ status: FontFamilyNotFound]
    at System.Drawing.GDIPlus.CheckStatus (System.Drawing.Status status)
[0x001e5] in <5eb1d9ccfec943adba5ae843e256d04f>:0
    at System.Drawing.FontFamily..ctor (System.Drawing.Text.GenericFontFamilies
genericFamily) [0x0005b] in <5eb1d9ccfec943adba5ae843e256d04f>:0
    at (wrapper remoting-invoke-with-check) System.Drawing.FontFamily:.ctor
(System.Drawing.Text.GenericFontFamilies)
    at System.Drawing.FontFamily.get_GenericSansSerif () [0x00000] in
<5eb1d9ccfec943adba5ae843e256d04f>:0
    at System.Drawing.Font.CreateFont (System.String familyName, System.Single
emSize, System.Drawing.FontStyle style, System.Drawing.GraphicsUnit unit,
System.Byte charSet, System.Boolean isVertical) [0x00014] in
<5eb1d9ccfec943adba5ae843e256d04f>:0
    at System.Drawing.Font..ctor (System.String familyName, System.Single
emSize, System.Drawing.FontStyle style, System.Drawing.GraphicsUnit unit,
System.Byte gdiCharSet, System.Boolean gdiVerticalFont) [0x00011] in
<5eb1d9ccfec943adba5ae843e256d04f>:0
    at System.Drawing.Font..ctor (System.String familyName, System.Single
emSize, System.String systemName) [0x00000] in
<5eb1d9ccfec943adba5ae843e256d04f>:0
    at (wrapper remoting-invoke-with-check) System.Drawing.Font:.ctor
(string,single,string)
    at System.Drawing.SystemFonts.get_DefaultFont () [0x00000] in
<5eb1d9ccfec943adba5ae843e256d04f>:0
    at System.Windows.Forms.Theme.get_DefaultFont () [0x0000d] in
<b4e6df1a5a1f4b78af726adaf5fd3ede>:0
    at System.Windows.Forms.Control.get_DefaultFont () [0x00005] in
<b4e6df1a5a1f4b78af726adaf5fd3ede>:0
    at System.Windows.Forms.Control.get_Font () [0x00031] in
<b4e6df1a5a1f4b78af726adaf5fd3ede>:0
    at System.Windows.Forms.Form..ctor () [0x00018] in
<b4e6df1a5a1f4b78af726adaf5fd3ede>:0
    at ClawLauncher.ClawLauncherForm..ctor () [0x00000] in
<a4adea8190ba4536856f18624a80285b>:0
    at (wrapper remoting-invoke-with-check) ClawLauncher.ClawLauncherForm:.ctor
()
    at ClawLauncher.Program.Main () [0x0003b] in
<a4adea8190ba4536856f18624a80285b>:0

  $ pkg install dejavu
  $ clawlauncher
  WARNING: The runtime version supported by this application is unavailable.
  Using default runtime: v4.0.30319
  Gtk not found (missing LD_LIBRARY_PATH to libgtk-x11-2.0.so.0?), using
built-in colorscheme

Probably no need to document dejavu as any usable font will do.

-- 
You are receiving this mail because:
You are the assignee for the bug.