[Bug 223545] [exp-run] patch(1) change to reject non-matching patches with limited context

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Thu Nov 9 23:17:29 UTC 2017


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223545

Pedro F. Giffuni <pfg at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pfg at FreeBSD.org

--- Comment #6 from Pedro F. Giffuni <pfg at FreeBSD.org> ---
(In reply to Kyle Evans from comment #0)

I have a small concern here: patch(1) should be able to apply any patch
generated by diff(1).

For the ports tree, in particular, it seems critical that anything generated
with "make makepatch" (diff -upn if I remember well) should always work with
patch(1).

I looked at some of the ports that are affected and portlint does complain
about the original patches: if it's just old patches that still apply by sheer
luck then it's OK, otherwise we shouldn't have to use specific diff flags to
generate valid patches.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-ports-bugs mailing list