[Bug 223397] [NEW PORT] audio/yoshimi

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223397

Tobias Kortkamp <tobik at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobik at freebsd.org

--- Comment #1 from Tobias Kortkamp <tobik at freebsd.org> ---
Thanks for your submission.  A short review below.

+PORTNAME=      yoshimi
+PORTVERSION=   1.5.4.1

You have invented a version number that has no basis in reality.  Why
is GH_TAGNAME set to a different commit than what was tagged as
1.5.4.1 by upstream?

Version 1.5.4.1 is commit efce85d and not 31291f0.

You may have to follow the procedure from [1] if you need newer
commits.

[1]
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex5

+COMMENT=       Yoshimi A Software synth

The port name shouldn't appear again in COMMENT.  The pkg-descr is not
very descriptive and could use some work too.  It sounds like a
Changelog entry.

+BUILD_DEPENDS= ninja:devel/ninja       \

ninja is implied by USES=cmake

+USES=          cmake:outsource \
+               pkgconfig

This should all be on one line.

+USE_XORG+=     x11 ice sm xext
+USE_GL+=       gl

Please replace += with =.

+USE_GITHUB=    yes
+GH_ACCOUNT=    Yoshimi
+GH_PROJECT=    yoshimi
+GH_TAGNAME=    31291f0

GH_{PROJECT,ACCOUNT} are set to ${PORTNAME} by default.  GitHub
project and account names are also case-insentive, so both
GH_{PROJECT,ACCOUNT} can go away here.

+MAKE_JOBS_UNSAFE=      yes

Why is this set?

+.include <bsd.port.pre.mk>
...
+.include <bsd.port.post.mk>

This isn't necessary here.  Just use .include <bsd.port.mk> at the
end.

+post-install:
+       @(mv ${STAGEDIR}${PREFIX}/share/man/man1/yoshimi.1
${STAGEDIR}${PREFIX}/share/man/yoshimi.1 && \
+       ${RM} -rf ${STAGEDIR}${PREFIX}/share/man/man1 && \
+       ${GZIP_CMD} ${STAGEDIR}${PREFIX}/share/man/yoshimi.1);

mv should be ${MV}.

> I also had to manually move and gzip the manual file and that causes
> portlint -AC to complain:

It complains because you moved it into the wrong place ;-).  Moving it
to ${PREFIX}/share/man is wrong.  It needs to go into
${PREFIX}/man/man1.  Gzipping man pages is done automatically when
there're installed into the right location.

+%%DATADIR%%/yoshimi-user-manual.pdf

This should probably go into ${DOCSDIR} too.

-- 
You are receiving this mail because:
You are the assignee for the bug.