[Bug 219609] [NEW PORT] science/tensorflow: Computation using data flow graphs for scalable machine learning

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219609

Kubilay Kocak <koobs at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needs-patch

--- Comment #5 from Kubilay Kocak <koobs at FreeBSD.org> ---
Initial review:

1) USES=python implies {RUN,BUILD}_DEPENDS on Python (can remove
python:lang/python). Additionally, use of python:lang/python is always
incorrect, as it only means 'depends on the `python` symlink' not 'depends on
python'. Only use USES=python:<args>

2) Upstream stipulates Python 2.7 *and* 3.3+ support. USES=python:2.7 limits it
to 2.7 only.

3) Regarding BROKEN (${OSVERSION} < 1100101):

3a) clang and llvm 3.8 exist in ports and can be depended on. If there is
nothing intrinsic or super-complex preventing other versions of FreeBSD from
building tensorflow, it should do so.

3b) If clang is not a requirement for building tensorflow, it should not be a
specific dependency. I see no mention of it on the 'building tensorflow from
sources' document, but further, there *is* mention of builds with GCC, which
motivates this comment.

USES=compiler:<args> should be used if a specific feature is required (See
Porters Handbook -- USES -- compiler for details [1])

4) Vendored dependencies should be extracted/removed and those ports/packages
in the tree depended on instead.

5) It's unlikely that all python dependencies are both RUN and BUILD
dependencies. Please make these as accurate to their actual dependency types as
possible.

6) -march=native should not be used for CC/CFLAGS. Binary packages are built
from ports and build host CPU architecture has no bearing on end-user hardware,
which may be different.

7) configuration (in this case ./configure) steps should be run in the
do-configure target, not the build target. Additionally and ideally, using
CONFIGURE_TARGET and other CONFIGURE_* variables, without requiring a custom
do-configure target override. If bazel is a pre build or 'configuration' step,
it should be done in the configure target as well.

8) Patching of WRKSRC files should occur in {pre,post}-patch target, not build
target.

9) Was using the port/package of pip tested rather than configuring/building
the  bundled tensorflow/tools/pip_package? The former should be used if and
where possible.

This port requires additional QA iterations

[1]
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#uses-compiler

-- 
You are receiving this mail because:
You are the assignee for the bug.