[Bug 219360] [ports-mgmt/portlint] [patch] JAVALIBDIR check is broken since 2.17.0

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219360

            Bug ID: 219360
           Summary: [ports-mgmt/portlint] [patch] JAVALIBDIR check is
                    broken since 2.17.0
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: marcus at FreeBSD.org
          Reporter: eugen at freebsd.org
          Keywords: patch
          Assignee: marcus at FreeBSD.org
             Flags: maintainer-feedback?(marcus at FreeBSD.org)

Created attachment 182673
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=182673&action=edit
unbreak test for JAVALIBDIR

portlint version 2.17.0 introduced variables expansion on all sides of the
dependency tuple. As a result, ${JAVALIBDIR} gets expanded and, so later check
for its value produces false FATAL error.

How-to-Repeat:

$ portlint /usr/ports/java/bouncycastle15 
FATAL: Makefile: you should use ${JAVALIBDIR} in BUILD_DEPENDS/RUN_DEPENDS to
define dependencies on JAR files installed in ${JAVAJARDIR}

Proposed fix moves the check for JAVALIBDIR before expansion code.

-- 
You are receiving this mail because:
You are the assignee for the bug.