[Bug 217993] net/samba44 fails to build with new Uses/samba.mk

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217993

--- Comment #3 from dewayne at heuristicsystems.com.au ---
(In reply to Antoine Brodin from comment #1)
Thank-you for looking into this.  With the exception of the bind9_11 line in
pkg-plist, we're very similar.  Perhaps as an aid, I've highlighted (with an
asterisk) the differences between a virgin build, where __MAKE_CONF=/dev/null
removes the influence of /etc/make.conf and my custom build.  There are NO
options files, as these are entirely controlled via etc/make.conf

# make __MAKE_CONF=/dev/null -C /usr/ports/net/samba44 showconfig | grep =on
     ACL_SUPPORT=on: File system ACL support
     ADS=on: Active Directory client support
     AD_DC=on: Active Directory Domain Controller support
  *  DEBUG=on: Build with debugging support
  *  DNSUPDATE=on: Dynamic DNS update (require ADS)
     DOCS=on: Build and/or install documentation
     FAM=on: File Alteration Monitor support
     LDAP=on: LDAP client support
     PTHREADPOOL=on: Pthread pool
  *  QUOTAS=on: Disk quota support
     SYSLOG=on: Syslog logging support
     UTMP=on: UTMP accounting support

What we are using:
# make -C /usr/ports/net/samba44 -DUSE_K8 showconfig | grep =on
     ACL_SUPPORT=on: File system ACL support
     ADS=on: Active Directory client support
     AD_DC=on: Active Directory Domain Controller support
     DOCS=on: Build and/or install documentation
     FAM=on: File Alteration Monitor support
     LDAP=on: LDAP client support
     PTHREADPOOL=on: Pthread pool
     SYSLOG=on: Syslog logging support
  *  BIND910=on: Use bind910 as AD DC DNS server frontend

I've included below, the unique "error"s while using a virgin build, using 
# make __MAKE_CONF=/dev/null -C /usr/ports/net/samba44 -DBATCH
-DMAKE_JOBS_UNSAFE clean package

In file included from ../source3/auth/auth_domain.c:29:
In file included from ../source3/libsmb/libsmb.h:26:
/usr/local/include/client.h:14:8: error: unknown type name 'dlink_list'
extern dlink_list user_list;

/usr/local/include/client.h:79:10: error: use of undeclared identifier
'NICKLEN'
        char id[NICKLEN+1];

/usr/local/include/client.h:197:23: error: conflicting types for 'find_service'
extern struct client *find_service(const char *name);

5 warnings and 19 errors generated.
Waf: Leaving directory `/usr/ports/net/samba44/work/samba-4.4.11/bin'
Build failed:  -> task failed (err #1):
        {task: cc auth_domain.c -> auth_domain_11.o}
  File "buildtools/bin/waf", line 76, in <module>
        Scripting.prepare(t, cwd, VERSION, wafdir)
  File
"/usr/ports/net/samba44/work/samba-4.4.11/third_party/waf/wafadmin/Scripting.py",
line 147, in prepare
        error(str(e))
*** Error code 1
patch-dynconfig__wscript

and for completeness there is no /usr/local/client.h, but 

# find /usr/ports/net/samba44/work/samba-4.4.11 -name client.h
/usr/ports/net/samba44/work/samba-4.4.11/ctdb/client/client.h
/usr/ports/net/samba44/work/samba-4.4.11/source3/include/client.h

Please note that these are different errors from my build, which did surprise
me.  I'll need to investigate further as we're also rebuilding FreeBSD
11.Stable 3 evenings a week at the moment (though I strongly doubt that as a
cause).

And thanks for the suggestion Mathieu.  I did try building 4.5 a few weeks ago.
 Unfortunately its quite challenging, and if you examine both the samba change
logs (or monitor the samba technical lists) you'll notice that there are also
some changes required to accomodate the os kernel; and jumping to the released
samba46 would be better use of effort. ;) Historically Timur has tracked these
changes and as you can see from /usr/ports/net/samba44/files many of the
FreeBSD customisations for samba are non-trivial; and beyond me (as I have been
absent from C programming for 27 years).

-- 
You are receiving this mail because:
You are on the CC list for the bug.