[Bug 219687] [NEW PORT] net/google-compute-engine: user daemon for Google Compute Engine

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219687

Helen Koike <helen.koike at collabora.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #183895|0                           |1
        is obsolete|                            |

--- Comment #5 from Helen Koike <helen.koike at collabora.com> ---
Created attachment 183898
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=183898&action=edit
Patch which adds google-compute-engine v2.4.0 in freebsd-ports

(In reply to Richard Gallamore from comment #4)

Hi Richard, thanks for reviewing this package, I am attaching a new version
with the suggested changes and a few other that I found in portlint (thanks for
suggesting this, I am still getting familiar with all the FreeBSD tools)

> Hey there Helen, thanks for submitting the port. After an initial scan, I have
> found a few items that need to be addressed.
> 
>   - Upstream versioning is by date. Why does this not match upstream?

This match upstream, it is just the github tag that is by date, the version is
in the setup.py file as shown here
https://github.com/GoogleCloudPlatform/compute-image-packages/commit/5824f1bba1906f6bb298db2efaf1bffc0671ff45

>   - Add license.

Done

>   - SUB_LIST is in USE section, should be after option section and before target
> section.

Done, I added just before "post-patch:" target, is it ok now?

>   - In pkg-descr, WWW, please list a site with plenty of documentation and
> information about the port. The git repo is lacking heavily on this.

I modified this to point to the main page where the docs are
https://github.com/GoogleCloudPlatform/compute-image-packages/
I think this is the most complete docs available

> 
> 
> Can you also please post a portlint -AC and attach a poudriere build logs if
> possible.
> 

I also adjusted pkg-desc so lines don't exceed 80 characters
And I removed DISTVERSION (as it cannot be user with PORTVERSION)

    -PORTVERSION=   2.4.0
    -DISTVERSION=   20170609
    +PORTVERSION=   20170609

But now it uses version 20170609 instead of 2.4.0, is this ok? I feel that
2.4.0 should be somewhere as it is the version used in setup.py, what do you
think?
I tried to use GH_TAGNAME=20170609 with PORTVERSION=2.4.0 but it doesn't seem
to work the way I imagined.

With these changes now portlint returns:
# portlint -AC
looks fine.

I'm attaching the poudriere logs in the comment that follows

Thanks for your help

-- 
You are receiving this mail because:
You are the assignee for the bug.