[Bug 220992] audio/xmms2-scrobbler broken

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220992

            Bug ID: 220992
           Summary: audio/xmms2-scrobbler broken
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: freebsd-ports-bugs at FreeBSD.org
          Reporter: emz at norma.perm.ru

Created attachment 184688
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=184688&action=edit
a patch fixing the 1.x Last.fm API support.

After Lasf.fm 1.x API bump during autumn 2015 xmms2-scrobbler stopped working.
Now it complains like

===Cut===
registering lastfm
starting thread for lastfm
no newline (1)
handshake failed
handshake failed
===Cut===

The attached patch resolves this problem, it was tested on 11.0-RELEASE-p5 and
last.fm. Various old bug reports (not FreeBSD PRs) state that xmms2-scrobbler
was working with Libre.fm _without_ this patch (at least in 2015), so it's
probably still working with Libre.fm and if it's so, it's very likely that this
patch will  break this _if_ Last.fm 1.x API differs from Libre API now. In this
case the port can be adjusted in a way when the user is prompted to chose which
API to assemble this port with (Last.fm - with this patch, others lLast.fm
derivatives - without). Since this PR is the only PR at this time mentioning
this port, and since the primary use of this port is the audioscrobbling to
Last.fm, as the pkg-descr states, I propose to just commit this patch in, until
some complaints about libre.fm will be received, if any. Then the dialog will
be added.

I cannot prove whether Libre.fm is working or not, since I don't have the
account there.

-- 
You are receiving this mail because:
You are the assignee for the bug.