[Bug 220873] Opencascade patch-src_STEPConstruct_STEPConstruct__AP203Context.cxx is wrong

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220873

            Bug ID: 220873
           Summary: Opencascade
                    patch-src_STEPConstruct_STEPConstruct__AP203Context.cx
                    x is wrong
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: freebsd-ports-bugs at FreeBSD.org
          Reporter: rcarter at pinyon.org

Opencascade patch-src_STEPConstruct_STEPConstruct__AP203Context.cxx is wrong

root at bruno> more patch-src_STEPConstruct_STEPConstruct__AP203Context.cxx
--- src/STEPConstruct/STEPConstruct_AP203Context.cxx.orig       2016-11-25
09:52:26 UTC
+++ src/STEPConstruct/STEPConstruct_AP203Context.cxx
@@ -123,7 +123,7 @@ Handle(StepBasic_DateAndTime) STEPConstr
     long shift = 0;
     _get_timezone (&shift);
   #else
-    Standard_Integer shift = Standard_Integer(timezone);
+    Standard_Integer shift = Standard_Integer((long long)timezone);
   #endif
     Standard_Integer shifth = abs ( shift ) / 3600;
     Standard_Integer shiftm = ( abs ( shift ) - shifth * 3600 ) / 60;
--More--(END)

timezone(3) on FreeBSD is a function whose address is a long long; on Linux,
via tzset(3) it is a global long integer.  Indeed the patch compiles, but I
doubt the result is what is intended.  I fixed this before getting so disgusted
with opencascade which required purging everything associated.  I regret that,
I should have kept my git branches around.

Anyway the solution is from memory a short static helper function inserted in
the source directly above the inline definition.

-- 
You are receiving this mail because:
You are the assignee for the bug.