[Bug 220548] "make cargo-crates" doesn't strip branch name

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220548

--- Comment #2 from Tobias Kortkamp <tobik at freebsd.org> ---
(In reply to Jan Beich from comment #1)
Looking at [1] I think we would need to strip ?tag= as well.

A dependency of e.g.

libc = {git = "https://github.com/rust-lang/libc", tag = "0.2.26"}

in Cargo.toml results in

[[package]]
name = "libc"
version = "0.2.26"
source =
"git+https://github.com/rust-lang/libc?tag=0.2.26#288942e6858a4b2f8ee56338da5386263b9c4b82"

in Cargo.lock and then the wrong GH_TUPLE output again:

GH_TUPLE=      
rust-lang:libc?tag=0.2.26:288942e6858a4b2f8ee56338da5386263b9c4b82:libc

which (given that we have an actual tag) probably should be

GH_TUPLE=       rust-lang:libc:0.2.26:libc

[1]
https://github.com/rust-lang/cargo/blob/master/src/doc/specifying-dependencies.md#specifying-dependencies-from-git-repositories

-- 
You are receiving this mail because:
You are on the CC list for the bug.