[Bug 216562] Mk/Uses/compiler.mk tramples over USE_GCC value with compiler:gcc-c++11-lib

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216562

            Bug ID: 216562
           Summary: Mk/Uses/compiler.mk tramples over USE_GCC value with
                    compiler:gcc-c++11-lib
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Ports Framework
          Assignee: portmgr at FreeBSD.org
          Reporter: mandree at FreeBSD.org
                CC: bapt at FreeBSD.org, freebsd-ports-bugs at FreeBSD.org,
                    portmgr at FreeBSD.org
             Flags: maintainer-feedback?(portmgr at FreeBSD.org), exp-run?
                CC: portmgr at FreeBSD.org

Issue:
When USES contains compiler:gcc-c++11-lib, 
Mk/Uses/compiler.mk will force USE_GCC=yes, 
instead of using USE_GCC?=yes.

Impact:
This harms ports that set, for instance, USE_GCC=5+, by re-allowing GCC 4.9
(which is known to miscompile rawtherapee on FreeBSD 11.0-RELEASE amd64, while
GCC 5.4 is fine).

Suggestion:
change code to USE_GCC?=yes here:

.if ${_COMPILER_ARGS:Mgcc-c++11-lib}
USE_GCC=        yes                         # <====-FIX-THIS-===============
CHOSEN_COMPILER_TYPE=   gcc
.if ${COMPILER_FEATURES:Mlibc++}
CXXFLAGS+=      -nostdinc++ -isystem /usr/include/c++/v1
LDFLAGS+=       -L${WRKDIR}


Workaround:
re-set USE_GCC after .include <bsd.port.pre.mk>. (See, for instance,
graphics/rawtherapee[-devel]).

-- 
You are receiving this mail because:
You are on the CC list for the bug.