[Bug 215815] [PATCH] multimedia/plexhometheater: un-BREAK

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215815

            Bug ID: 215815
           Summary: [PATCH] multimedia/plexhometheater: un-BREAK
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: woodsb02 at freebsd.org
          Reporter: kalten at gmx.at
          Keywords: patch
             Flags: maintainer-feedback?(woodsb02 at freebsd.org)
          Assignee: woodsb02 at freebsd.org

Created attachment 178567
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=178567&action=edit
unbreak by const_cast

Currently this port is marked broken with the description:
“Fails to build against libsamplerate-0.1.9”.

When I deleted the “BROKEN=” line, the following Error came up:
> /wrkdirs/usr/ports/multimedia/plexhometheater/work/plex-home-theater-public-1.4.1.469-47a90f01/xbmc/cores/dvdplayer/DVDPlayerAudioResampler.cpp:77:12: error: cannot initialize a variable of type 'float *' with an lvalue of type 'const float *'
>   float*   outputptr = m_converterdata.data_in;
>            ^           ~~~~~~~~~~~~~~~~~~~~~~~

I do not understand the BROKEN-message compared to the compiler-error.

I did cast to float*—analogous to other code there, although using
const_cast—as this seems what is intended (see attachment) and now it does
compile and seems to work.
The original authors should be told about it, I presume.

Am I missing something?

Regards,
 Kalten

-- 
You are receiving this mail because:
You are the assignee for the bug.