[Bug 217322] [NEW PORT] devel/fifechan : fifengine's team fork guichan

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217322

Tobias Kortkamp <tobik at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open
                 CC|                            |tobik at freebsd.org
           Assignee|freebsd-ports-bugs at FreeBSD. |tobik at freebsd.org
                   |org                         |

--- Comment #1 from Tobias Kortkamp <tobik at freebsd.org> ---
Thanks for your submission.  Some comments:

- Please use USE_GITHUB, GH_PROJECT, etc. (see
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-description)
instead of setting MASTER_SITES and DISTFILES

- Please only indent with 1 tab after variables

- What do the SHARED_* variables do?

- The pkg-descr could be a little more detailed.  Currently it's basically the
same as the COMMENT

- Have you done any test building with Poudriere or Synth?

- What does portlint say about the port?

- What is the purpose of plist.sdlc?

-- 
You are receiving this mail because:
You are the assignee for the bug.