[Bug 217105] [New Port]: devel/memleax Debugs memory leak of a running process by attaching it, without recompiling or restarting.

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217105

Tobias Kortkamp <tobik at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobik at freebsd.org
             Status|New                         |Open
           Assignee|freebsd-ports-bugs at FreeBSD. |tobik at freebsd.org
                   |org                         |

--- Comment #6 from Tobias Kortkamp <tobik at freebsd.org> ---
Hi Guy,

there are still some minor problems with this.  If you fix them I'll
submit the port for review, and commit it :)

- There are still some Portlint warnings that need to be fixed (use
  portlint -A to get additional warnings, see [1]):

        WARN: /usr/home/tobias/Downloads/memleax/pkg-plist: There are
        only 2 items in the plist.  Consider using PLIST_FILES instead
        of pkg-plist when installing less than 6 items.
        FATAL: Makefile: [10]: use a tab (not space) after a variable name
        ...
        8 fatal errors and 1 warning found.

- The v in PORTVERSION is wrong.  Use DISTVERSIONPREFIX if the version
  (GitHub tag) is prefixed by something else  
- GH_PROJECT is unnecessary when PORTNAME is the same
- Indent with one tab only after variable names
- It is shorter to do the installation manually like this:

  do-install:
        ${INSTALL_PROGRAM} ${WRKSRC}/memleax ${STAGEDIR}${PREFIX}/bin
        ${INSTALL_MAN} ${WRKSRC}/memleax.1 ${STAGEDIR}${PREFIX}/man/man1

- Use PLIST_FILES instead of pkg-plist since the port only installs 2 files:

  PLIST_FILES=  bin/memleax \
                man/man1/memleax.1.gz

- I don't think I can get the pkg-descr past my mentors.  Can you
  describe memleax in slightly more detail here?

- devel/libdwarf does not provide libdwarf.so but only provides a
  static library libdwarf.a, so the LIB_DEPENDS line for it is
  probably wrong.  The README claims that memleax will work with
  ports' libdwarf only [2].  Is this true or will it work fine with
  base's version?

[1] https://www.freebsd.org/doc/en/books/porters-handbook/testing-portlint.html
[2] https://github.com/WuBingzheng/memleax#build-from-source

-- 
You are receiving this mail because:
You are the assignee for the bug.