[Bug 217219] sysutils/pftop includes pcap-int.h

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217219

            Bug ID: 217219
           Summary: sysutils/pftop includes pcap-int.h
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: araujo at FreeBSD.org
          Reporter: guy at alum.mit.edu
          Assignee: araujo at FreeBSD.org
             Flags: maintainer-feedback?(araujo at FreeBSD.org)

As reported in libpcap GitHub issue #560:

    https://github.com/the-tcpdump-group/libpcap/issues/560

pftop fails to build.

The problem is that 1) it's including a *libpcap-internal* header file,
pcap-int.h, which FreeBSD, for some reason, apparently sees fit to install as a
system header file (thus not discouraging programmers from including pcap-int.h
and potentially depending on internals that are not only subject to change from
release to release but that have changed *quite* a bit over time), and 2) that
header file has, in fact, changed to include another *libpcap-internal* header
file, portability.h.

I see nothing in any of the pftop code that even uses libpcap - it has what
appears to be a private fork of libpcap's BPF compiler.  libpcap's BPF compiler
source files include pcap-int.h, but that's because they're *part of libpcap*
and look at some data about the pcap_t for which they're compiling code;
pftop's BPF compiler doesn't even have a pcap_t to look at.

Ripping out the includes of pcap-int.h, and copying over any declarations or
definitions needed for pftop, would fix this problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.