[Bug 217046] net/ceph-devel: Development version for Ceph, a distributed object, block, and file storage platform

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217046

Alan Somers <asomers at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |asomers at FreeBSD.org

--- Comment #3 from Alan Somers <asomers at FreeBSD.org> ---
Why are there so many commented fields near the top of the Makefile?

Is git really a BUILD_DEPEND?  If anything, it's usually a FETCH_DEPEND.  But
if you're using USE_GITHUB, I think that's implied.

What is OTHER_DEPENDS?  I've never seen that before.

TEST_DEPENDS, and all of the other commented out code, should be removed.

Have you tried building with Poudriere?  If you're missing any dependencies,
Poudriere will find out.  It'll also catch any errors in your pkg-plist.

Likewise, you should try using portlint.  It'll catch some of the stuff that I
did.

Some comments have > 80 chars/line.  Please shorten them.

Do you need to specify GH_ACCOUNT when you're using GH_TUPLE?

s/atleast/at least/

Please don't manually specify "-j" to gmake.  It prevents ports/poudriere from
managing the number of jobs.  Instead, just say
"INSTALL_WRKSRC=${WRKSRC}/build".

Is it really necessary to put all the MKDIRs in post-stage:?  I thought the
@dir directive in pkg-plist was sufficient.

In post-stage: don't use CP for init-ceph.  Instead, use INSTALL so you can set
the mode correctly.  I think it's also more common to do that kind of thing in
post-install, though post-stage will also work.

Why are there @comment lines in the pkg-plist?

Please delete the blank lines at the end of every file.

There's some garbage in line 6 of the pkg-descr file.

The third bullet of pkg-descr is incorrectly indented.

The third paragraph of pkg-descr probably isn't appropriate material for a
pkg-descr file, though it satisfies my personal curiosity about why you've put
in so much effort.

In files/ceph.in, please put a newline after a leading {

Never hardcode "/usr/local" into an rc script.  Instead, use %%PREFIX%%.  It'll
be expanded automatically, thanks to USE_RC_SUBR.

Question:  which components of Ceph have you gotten running on FreeBSD?  I'm
assuming the OSD runs.  Can FreeBSD also run an MDS or a Monitor node?

For a port this complicated, it would be easier to review if you open a code
review at https://reviews.freebsd.org/.  I think you can login with your github
credentials.

-- 
You are receiving this mail because:
You are the assignee for the bug.