[Bug 221801] www/tdom: port passes $LDFLAGS to direct linker invocation, not compiler driver

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221801

            Bug ID: 221801
           Summary: www/tdom: port passes $LDFLAGS to direct linker
                    invocation, not compiler driver
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: freebsd-ports-bugs at FreeBSD.org
          Reporter: emaste at freebsd.org
                CC: mi at ALDAN.algebra.com
                CC: mi at ALDAN.algebra.com
             Flags: maintainer-feedback?(mi at ALDAN.algebra.com)

I've been investigating the state of the ports tree with LLVM's lld installed
as /usr/bin/ld (from the exp-run in PR 214864).

Normally LDFLAGS contains flags passed to the compiler driver when invoked for
linking. One issue that affects a small number of ports is passing $LDFLAGS to
direct linker invocation (i.e, $LD), where it contains flags that are
appropriate only for the compiler driver, not the linker.

In several instances this comes from bsd.ssp.mk, which adds -fstack-protector
to LDFLAGS.  GNU BFD ld accepts the flag but produces undesired output, while
lld produces an error:

ld -fstack-protector -shared -o libcfg+.so.0 ../src/cfg+.o ../src/parse.o
../src/props.o ../src/cmdline.o ../src/cfgfile.o ../src/shared.o
../src/platon/str/strplus.o ../src/platon/str/strctype.o
../src/platon/str/strdyn.o ../src/platon/str/dynfgets.o
ld: error: unknown argument: -fstack-protector
(from devel/libcfg)

(GNU ld produces output with a bogus DT_AUXILIARY "stack-protector" entry for
this case.)

This affects at least the following ports:
www/mod_jk
devel/libcfg
arabic/libitl
www/tdom
www/dummyflash
ftp/rexx-curl

www/tdom build excerpt:
ld -Bshareable -x -o libtdom0.8.3.so xmlrole.o xmltok.o xmlparse.o xmlsimple.o
utf8conv.o dom.o domhtml.o domxpath.o domxslt.o domlock.o tcldom.o nodecmd.o
tdominit.o tclexpat.o tdomStubInit.o  -L/usr/local/lib -ltclstub86 
-fstack-protector -export-dynamic
ld: error: unknown argument: -fstack-protector

-- 
You are receiving this mail because:
You are the assignee for the bug.