[Bug 220978] mail/dcc-dccd: Mixes data and code, does not respect hier(7)

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220978

--- Comment #4 from Richard Gallamore <ultima at freebsd.org> ---
(In reply to Piotr Kubaj from comment #3)
Keeping /usr/local/dcc is fine, /var/db/dcc should work as well. /var/dcc wont
be acceptable however. I know this is the vendor's default for dcc-dccd, but
this simply is not an acceptable location for any FreeBSD port to reside.



I have a couple of questions about this patch,

1: DCCDATA knob seems more like a complete change of DCCHOME. Is this supposed
to be an option? It would probably be better to add an option simply changing
the DCCHOME var instead. For example,
ALT_HOME_VAR=      DCCHOME=/var/db/dcc
ALT_HOME_VAR_OFF=  DCCHOME=${PREFIX}/dcc
* The pkg-message has %%DCCHOME%%/dcc_conf while this was changed in pkg-plist.
3: I like this change, but I am worried about some of the scripts not working
correctly. This will need to be verified.
4: Looks good
5: with the configure_arg, --without-DCC-MD5 this shouldn't be linked at all
correct? removing it completely as you have should be fine.


As for further improvements:
 Changing files/*.in should be as easy as adding %%DCCHOME%%/DCCHOME= to the
file/SUB_LIST.

I don't think there really is a standard directory for cgi-bin. Don't know
enough about the port to know if this is important enough to move.

-- 
You are receiving this mail because:
You are the assignee for the bug.