[Bug 212956] [PATCH] USES/go.mk, add GO_EXTRA_PACKAGES for multi-package applications

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sat Sep 24 05:43:00 UTC 2016


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212956

            Bug ID: 212956
           Summary: [PATCH] USES/go.mk, add GO_EXTRA_PACKAGES for
                    multi-package applications
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Only Me
          Priority: ---
         Component: Ports Framework
          Assignee: portmgr at FreeBSD.org
          Reporter: bsdports at kyle-evans.net
                CC: freebsd-ports-bugs at FreeBSD.org
          Keywords: patch

Created attachment 175116
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=175116&action=edit
svn(1) diff of Mk/Uses/go.mk to add GO_EXTRA_PACKAGES

I've ran into a golang application ([1]) that is actually composed of four
different packages within its own repository, plus a couple of external
dependencies.

Currently, this makes for kind of an ugly situation where one would need to put
these into their proper ${GO_SRCDIR}/${PACKAGENAME} paths in order to properly
build, and it gets kind of messy. Additionally, the behavior for creating
${GO_WRKSRC} is out-right wrong because the repository is already
package-aware.

I'm attaching a patch that handles this situation a little better with a
GO_EXTRA_PACKAGES var.

If GO_EXTRA_PACKAGES is populated, then:

* Make sure that ${GO_PKGNAME} is included -- for multi-package repositories,
this should *always* work as it's the only sane layout I can think of

* In post-extract we assume/check that each package is currently living in
${WRKSRC}/src and symlink it into place if proper.


[1] https://github.com/arduino/arduino-builder

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-ports-bugs mailing list