[Bug 207929] [NEW PORT] biology/jellyfish: Fast, memory-efficient counting of k-mers in DNA

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207929

Raphael Kubo da Costa <rakuco at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rakuco at FreeBSD.org

--- Comment #2 from Raphael Kubo da Costa <rakuco at FreeBSD.org> ---
Some suggestions after a quick review:

* You can drop the pkg-config sed call and replace it with USES=pathfix and
PATHFIX_MAKEFILEIN=Makefile.am.
* The version and architecture checks can be simplified:
  1. Use a helper to mark the port as broken:
     BROKEN_FreeBSD_9_i386= multiple code issues on i386 < 10.0-RELEASE
  2. Use MACHINE_CPU to check if the CPU supports SSE:
     .if empty(MACHINE_CPU:sse)
     CONFIGURE_ARGS+= --without-sse
     .endif
  This also allows you to just include bsd.port.mk.
* BUILD_DEPENDS+= should be BUILD_DEPENDS=
* Should --without-sse work on amd64? I tried passing it here and the build
failed.

-- 
You are receiving this mail because:
You are the assignee for the bug.