[Bug 210198] remove dead things, simplify & refactor do-fetch, extract create-manifest...

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sun Jun 19 11:25:44 UTC 2016


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210198

--- Comment #8 from commit-hook at freebsd.org ---
A commit references this bug:

Author: mat
Date: Sun Jun 19 11:25:30 UTC 2016
New revision: 417110
URL: https://svnweb.freebsd.org/changeset/ports/417110

Log:
  Remove unnecessary evals that do-fetch was using.

  Turns out that env(1) knows how to parse a properly quoted string
  using -S "string", it makes the double eval used for the fetch
  command to be unnecessary.

  This is because running:
  eval "foo $(escape $bar)"
  is silly when this works:
  foo $bar

  So remove escaping and quoting, and sillyness.

  PR:           210198
  Submitted by: mat
  Exp-run by:   antoine
  Sponsored by: The FreeBSD Foundation, Absolight
  Differential Revision:        https://reviews.freebsd.org/D6779

Changes:
  head/Mk/Scripts/checksum.sh
  head/Mk/Scripts/do-fetch.sh
  head/Mk/bsd.port.mk
  head/games/narcissu2/Makefile
  head/graphics/waifu2x-converter-cpp/Makefile
  head/shells/ksh93/Makefile
  head/sysutils/geomWatch/Makefile
  head/textproc/kmfl-sil-ezra/Makefile
  head/textproc/kmfl-sil-ipa-unicode/Makefile
  head/textproc/kmfl-sil-panafrican-latin/Makefile
  head/www/xpi-splash/Makefile

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-ports-bugs mailing list