[Bug 210068] sysutils/ipmitool: cleanup

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210068

            Bug ID: 210068
           Summary: sysutils/ipmitool: cleanup
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch, patch-ready
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: zi at FreeBSD.org
          Reporter: nevecherya at gmail.com
          Assignee: zi at FreeBSD.org
             Flags: maintainer-feedback?(zi at FreeBSD.org)

Created attachment 171083
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=171083&action=edit
Cleanup patch

patch-lib_ipmi__chassis.c don't needed. See lib/ipmi__chassis.c after patch.

#include <ipmitool/bswap.h>
#include <ipmitool/helper.h>
#include <ipmitool/ipmi.h>
#include <ipmitool/log.h>
#include <ipmitool/ipmi_intf.h>
#include <ipmitool/ipmi_strings.h>
#include <ipmitool/ipmi_chassis.h>
#include <ipmitool/bswap.h>

patch-lib_ipmi__pef.c don't needed. See lib/ipmi__pef.c after patch.

#include <ipmitool/bswap.h>
#include <ipmitool/helper.h>
#include <ipmitool/log.h>
#include <ipmitool/ipmi.h>
#include <ipmitool/ipmi_intf.h>
#include <ipmitool/ipmi_pef.h>
#include <ipmitool/bswap.h>

#define s6_addr16 __u6_addr.__u6_addr16 don't need in
patch-src_plugins_ipmi__intf.c
#define _XOPEN_SOURCE 700
...
#include <netinet/in.h>
#include <arpa/inet.h>

==> automated #include <netinet6/in.h6>

Compilation do without any problems in FreeBSD 9.3 and FreeBSD 10.3

In /src/plugins/open/open.c
-#define _POSIX_SOURCE
+#define _POSIX_C_SOURCE 1
is more correct.

In main port Makefile
CONFIGURE_ARGS+=--disable-intf-usb
need only. The other parameters in configure set correctly by default.

xenable_intf_bmc=no
xenable_intf_imb=yes
xenable_intf_open=yes
xenable_intf_usb=yes
xenable_intf_lipmi=yes
#xenable_intf_serial=yes
xenable_intf_dummy=no
xenable_all_options=yes
xenable_ipmishell=yes
...
*freebsd*)
        xenable_intf_imb=no
        xenable_intf_lipmi=no
        xenable_intf_bmc=no
        ;;

See this https://sourceforge.net/p/ipmitool/bugs/445/

-- 
You are receiving this mail because:
You are the assignee for the bug.