[Bug 209354] mail/davmail: Update to 4.7.2

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209354

Jason Unovitch <junovitch at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |In Progress
           Assignee|freebsd-ports-bugs at FreeBSD. |junovitch at freebsd.org
                   |org                         |
                 CC|                            |junovitch at freebsd.org

--- Comment #5 from Jason Unovitch <junovitch at freebsd.org> ---
I think the non-root is certainly a good best practice but don't see that as
enough to merge to quarterly without a known issue against it.

I have some issues with the patch.

1. It fails to even start because it doesn't make the users.

# service davmail onestart
install: unknown group davmail

It needs:
USERS=  davmail
GROUPS= davmail

2. It doesn't make the pidfile directory

# service davmail onestart
install: mkdir : No such file or directory

The davmail.in should probably do something more like:
pidfiledir="/var/run/davmail"
pidfile="${pidfiledir}/davmail.pid"

${pidfiledir} is currently undefined, hense the error.

3. davmail_daemon() also hard codes the username... it should be
${davmail_user}.

Even after all that the service doesn't actually start.  If you can update the
patch and verify it runs I'll go ahead and review this for commit.  Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.