[Bug 210450] [NEW PORT] devel/liteide: Simple, open source, cross-platform Go IDE

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210450

--- Comment #8 from Jan Beich <jbeich at FreeBSD.org> ---
Created attachment 172301
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=172301&action=edit
minor style changes

The following is bogus

  QT5_USE=      ... gl

and should be

  QT5_USE=      ... GL=gl

or removed by adding

  LDFLAGS+=     -Wl,--as-needed

-lGL seems to be pulled by QtGui.

------------------

USE_QT5=webkit is unused according to *-qt5.log

   0x00000001 (NEEDED)                     Shared library: [libQt5Core.so.5]
   0x00000001 (NEEDED)                     Shared library: [libQt5Gui.so.5]
   0x00000001 (NEEDED)                     Shared library: [libQt5Network.so.5]
   0x00000001 (NEEDED)                     Shared library:
[libQt5PrintSupport.so.5]
   0x00000001 (NEEDED)                     Shared library: [libQt5Widgets.so.5]
   0x00000001 (NEEDED)                     Shared library: [libQt5Xml.so.5]

However, liteidex/src/plugins/webkithtmlwidget/webkithtmlwidget.pro actually
supports it

  greaterThan(QT_MAJOR_VERSION, 4) {
  QT += webkitwidgets
  } else {
  QT += network
  QT += webkit
  }

but disabled by liteidex/liteidex.pri

  linux* {
      contains(CONFIG, liteide_qtwebkit) {
          DEFINES += LITEIDE_QTWEBKIT
      }
  } else {
      greaterThan(QT_MAJOR_VERSION, 4) {
      } else {
          DEFINES += LITEIDE_QTWEBKIT
      }
  }

(In reply to Dmitri Goutnik from comment #6)
> Jan, I'm not quite sure what you mean by visually confusuing but I
> looked at other ports that have QT4/QT5 as build options and
> rearranged USEs a bit.

Options and their helpers generally go at the bottom just before conditionals
and target definitions. I'm attaching a patch to illustrate but the last word
is up to you, the maintainer.

-- 
You are receiving this mail because:
You are the assignee for the bug.