[Bug 210876] multimedia/assimp: Update to 3.3

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210876

--- Comment #9 from lightside <lightside at gmx.com> ---
(In reply to comment #8)
> Ok, you need to create patches with 'svn diff', they always apply easy.
I used sources from portsnap and created patch with `diff -ruN assimp.orig
assimp > assimp.diff`, the command of which also mentioned in attachment
#172218. I wrote how to apply such kind of patch(es) in comment #6 and there
were no problems in other PRs with this.

(In reply to comment #8)
> Let's put this on hold in the hope that they will re-release it.
Agreed, based on description in current v3.3 tag:
https://github.com/assimp/assimp/commit/19769eef8b9612a82fdb55c245db871476e7f178
"Version: prepare 3.3 version.", they (still) prepare it. There are no
description of changes for 3.3 version in current commit:
https://github.com/assimp/assimp/blob/19769eef8b9612a82fdb55c245db871476e7f178/CHANGES

You commented on https://github.com/assimp/assimp/issues/940
> pstdint.h isn't of the latest version. You have 0.1.12 and the current
> version is 0.1.15.4. The FreeBSD port for some reason patches it to 0.1.15.4.
> I am not sure why, somebody needed the latest version. But why don't you just
> update it in here, upstream?
The reasons are:
- The 3.2 version in bug 209356 required newer pstdint.h file to fix build on
FreeBSD 10.x.
- Between 3.2 and 3.3 versions the pstdint.h was custom patched in
https://github.com/assimp/assimp/issues/795 to 0.1.12 version. It gives
following warnings on FreeBSD 10.2, for example:
-8<--
In file included from
/usr/ports/multimedia/assimp/work/assimp-19769ee/contrib/irrXML/irrXML.cpp:12:
In file included from
/usr/ports/multimedia/assimp/work/assimp-19769ee/contrib/irrXML/./../../code/fast_atof.h:29:
/usr/ports/multimedia/assimp/work/assimp-19769ee/include/assimp/Compiler/pstdint.h:678:10:
warning: 'UINT_FAST64_MAX' macro redefined
# define UINT_FAST64_MAX UINT_LEAST64_MAX
         ^
/usr/include/x86/_stdint.h:136:9: note: previous definition is here
#define UINT_FAST64_MAX UINT64_MAX
        ^

In file included from
/usr/ports/multimedia/assimp/work/assimp-19769ee/contrib/irrXML/irrXML.cpp:12:
In file included from
/usr/ports/multimedia/assimp/work/assimp-19769ee/contrib/irrXML/./../../code/fast_atof.h:29:
/usr/ports/multimedia/assimp/work/assimp-19769ee/include/assimp/Compiler/pstdint.h:674:10:
warning: 'INT_FAST32_MIN' macro redefined
#define  INT_FAST32_MIN  INT_LEAST32_MIN
         ^
/usr/include/x86/_stdint.h:123:9: note: previous definition is here
#define INT_FAST32_MIN  INT32_MIN
        ^

In file included from
/usr/ports/multimedia/assimp/work/assimp-19769ee/tools/assimp_cmd/ImageExtractor.cpp:47:
In file included from
/usr/ports/multimedia/assimp/work/assimp-19769ee/include/../code/fast_atof.h:29:
/usr/ports/multimedia/assimp/work/assimp-19769ee/include/assimp/Compiler/pstdint.h:320:12:
warning: 'INT8_C' macro redefined
#   define INT8_C(v) ((int8_t) v)
           ^
/usr/include/x86/_stdint.h:45:9: note: previous definition is here
#define INT8_C(c)               (c)
        ^

etc.
-->8-
Therefore, it's advisable to patch it for 3.3 version also. I think, you need
to point upstream to official source of pstdint.h file, if you want to resolve
this on upstream level:
http://www.azillionmonkeys.com/qed/pstdint.h

-- 
You are receiving this mail because:
You are the assignee for the bug.