[Bug 207299] print/muttprint: Update to 0.73

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207299

--- Comment #8 from Raphael Kubo da Costa <rakuco at FreeBSD.org> ---
Questions I have about the patch:
- Can't you avoid patching Makefile.am if you just install the additional
documentation files yourself in the post-install target?
- Why are the translated man pages not being installed?
- Does doc/manpages/en/muttprint.pod as-is cause build issues?
- Is installing the original files listed in pics/Makefile.am a problem? If
not, you could get rid of the patch and just install Beastie.eps in
post-install.

And something to consider but not exactly urgent:
- You should convert checks for certain options to options helpers. For
example:
  .if ${PORT_OPTIONS:MX11}
  RUN_DEPENDS+= convert:${PORTSDIR}/graphics/ImageMagick
  .else
  RUN_DEPENDS+=   convert:${PORTSDIR}/graphics/ImageMagick-nox11
  .endif

  becomes

  X11_RUN_DEPENDS=convert:${PORTSDIR}/graphics/ImageMagick
  X11_RUN_DEPENDS_OFF=convert:${PORTSDIR}/graphics/ImageMagick-nox11
- The same applies to options helpers in targets. Fore xample:
  post-patch:
  # ...
  .if ${PORT_OPTIONS:MCUPS}
    @${REINPLACE_CMD} 's|lpr $$CUPS_OPTIONS|${PREFIX}/bin/lpr $$CUPS_OPTIONS|'
${WRKSRC}/muttprint
  .endif

  becomes

  post-patch-CUPS-on:
    @${REINPLACE_CMD} 's|lpr $$CUPS_OPTIONS|${PREFIX}/bin/lpr $$CUPS_OPTIONS|'
${WRKSRC}/muttprint

-- 
You are receiving this mail because:
You are the assignee for the bug.