[Bug 206956] x11-wm/herbstluftwm: update to 0.7.0

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206956

--- Comment #6 from Raphael Kubo da Costa <rakuco at FreeBSD.org> ---
I've just tested the patch on 9.3-i386 again and it worked now.

I only have one comment this time: setting both VERBOSE and COLOR in MAKE_ARGS
is redundant. If you set VERBOSE="", then that colorecho function in colors.mk
will not be defined and the COLOR_* variables won't be used at all, so doing
COLOR=0 is unnecessary. On the other hand, if you do COLOR=0 without
VERBOSE="", you get non-verbose build output without colors, which also solves
the tput warnings issue. I think you should decide whether you prefer verbose
or non-verbose build output and set one variable or the other based on that.

-- 
You are receiving this mail because:
You are the assignee for the bug.