[Bug 206956] x11-wm/herbstluftwm: update to 0.7.0

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206956

--- Comment #3 from Raphael Kubo da Costa <rakuco at FreeBSD.org> ---
> Do you have any idea about tput warnings? Or are they important?

The tput warnings likely come from here:
https://github.com/herbstluftwm/herbstluftwm/blob/v0.7.0/colors.mk and are just
used for decorating the output of non-verbose builds. One quick way to get rid
of those warnings is to force a verbose build (i.e. add "VERBOSE=" to
MAKE_ARGS).

> And maybe it's enough to disable unrecognized command line options? I think the -W* is okay, but what about -std=c++11?

You are approaching this from the wrong point of view. While it could be
possible to remove the unrecognized warnings from the command line, you cannot
rewrite the source code in C++98 instead of C++11. Upstream has made a choice
to use C++11 in its code, so you need to adapt the port to follow suit.

With that said, that's what we have USES=compiler for. USES=compiler:c++11-lang
adds a build-time dependency on a compiler that understands C++11 (and
consequently the -std=c++11 flag). It is not enough in this case, though, since
the port also uses C++11 features from the standard library (such as the
<array> header). This means you need USES=compiler:c++11-lib instead.

Since we're talking about the port anyway, I have a few suggestions for you:
- Instead of doing LDXX=c++ in the Makefile, LDXX=${CXX} is more flexible.
- Keep an eye on what upstream does to the build system in the next releases: I
was checking
https://github.com/herbstluftwm/herbstluftwm/compare/v0.6.2...v0.7.0 to comment
here, and it looks like they've started working on porting their build system
away from their home-baked solution to CMake. It's still experimental, but you
might want to consider switching to it in the future.

-- 
You are receiving this mail because:
You are the assignee for the bug.