[Bug 206886] math/openblas: Update to 0.2.15

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sun Feb 7 13:44:21 UTC 2016


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206886

--- Comment #8 from Raphael Kubo da Costa <rakuco at FreeBSD.org> ---
The new patch may risk introducing the bug that the commit adding priorities to
the constructor and destructor attributes tried to fix
(https://github.com/xianyi/openblas/issues/654) even for GCC versions which do
support that feature (basically anything newer than base GCC).

How about this instead:

--- driver/others/memory.c
+++ driver/others/memory.c
@@ -142,7 +142,7 @@ USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
SUCH DAMAGE.
 #if defined(_MSC_VER) && !defined(__clang__)
 #define CONSTRUCTOR __cdecl
 #define DESTRUCTOR __cdecl
-#elif defined(OS_DARWIN) && defined(C_GCC)
+#elif defined(OS_DARWIN) || (defined(C_GCC) && ((__GNUC__ == 4) &&
(__GNUC_MINOR__ < 3)))
 #define CONSTRUCTOR    __attribute__ ((constructor))
 #define DESTRUCTOR     __attribute__ ((destructor))
 #else

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list