[Bug 206910] [PATCH] x11-toolkits/scintilla & editors/scite: Update to v3.6.3

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206910

            Bug ID: 206910
           Summary: [PATCH] x11-toolkits/scintilla & editors/scite: Update
                    to v3.6.3
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: freebsd-ports-bugs at FreeBSD.org
          Reporter: lightside at gmx.com
                CC: cyberbotx at cyberbotx.com
             Flags: maintainer-feedback?(cyberbotx at cyberbotx.com)
                CC: cyberbotx at cyberbotx.com
          Keywords: patch

Created attachment 166538
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=166538&action=edit
Proposed patch for x11-toolkits/scintilla (since 402317 revision)

Patch to update x11-toolkits/scintilla and editors/scite ports from 3.6.2 to
3.6.3 version.

Look following link for changes:
http://www.scintilla.org/ScintillaHistory.html

x11-toolkits/scintilla:
- Update files/patch-makefile
- Add a sed patch to remove used PICFLAGS define from provided gtk/makefile,
which makes it possible to differentiate between "-fPIC" and "-fpic" flags as
it was before 3.6.3 version, based on processor architecture in port's Makefile

I'm not sure about sed patch for PICFLAGS define, but there are various changes
related to "-fPIC" and/or "-fpic" flags in svn history of
x11-toolkits/scintilla port:
- "Update to 1.38" (removal of -fPIC flag):
https://svnweb.freebsd.org/ports/head/x11-toolkits/scintilla/files/patch-makefile?r1=41542&r2=43584
- "Fix build on sparc64 by not adding -fpic to CFLAGS":
https://svnweb.freebsd.org/ports/head/x11-toolkits/scintilla/Makefile?r1=106784&r2=127988
- "Add -fPIC to CFLAGS to fix the build on amd64":
https://svnweb.freebsd.org/ports/head/x11-toolkits/scintilla/Makefile?r1=127988&r2=145528
- "Make sure the PIC CFLAGS are properly used for all objects":
https://svnweb.freebsd.org/ports/head/x11-toolkits/scintilla/files/patch-makefile?r1=127988&r2=145531
- "Fix linking and sparc64 build; small clean-up":
https://svnweb.freebsd.org/ports/head/x11-toolkits/scintilla/Makefile?r1=281243&r2=281725

According to these svn logs and current GCC manual documentation
(https://gcc.gnu.org/onlinedocs/gcc-5.3.0/gcc/Code-Gen-Options.html#index-fpic-2808),
there are actual differences between "-fPIC" and "-fpic" flags, therefore I
decided to propose a sed patch for what it was before 3.6.3 version.

-- 
You are receiving this mail because:
You are the assignee for the bug.