[Bug 215353] emulators/open-vm-tools emulators/open-vm-tools-nox11: Fix build after sysctl changes in head r310051

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215353

            Bug ID: 215353
           Summary: emulators/open-vm-tools emulators/open-vm-tools-nox11:
                    Fix build after sysctl changes in head r310051
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: swills at FreeBSD.org
          Reporter: dim at FreeBSD.org
          Assignee: swills at FreeBSD.org
             Flags: maintainer-feedback?(swills at FreeBSD.org)

Created attachment 178024
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=178024&action=edit
Fix sysctl_add_oid() for head after r310051

After head r310051, where the prototype of sysctl_add_oid(9) has changed,
adding one extra parameter, previously built vmmemctl.ko modules insta-panic
the kernel.

Additionally, attempting to rebuild the open-vm-tools ports with the new
prototype results in errors in the vmmemctl module now:

os.c:894:46: error: too few arguments to function call, expected 11, have 10
                         BALLOON_NAME_VERBOSE);
                                             ^
/usr/src/sys/sys/sysctl.h:1014:1: note: 'sysctl_add_oid' declared here
struct sysctl_oid *sysctl_add_oid(struct sysctl_ctx_list *clist,
^
1 error generated.

For some reason, the vmmemctl module does not make use of the SYSCTL_ADD_OID
macro from <sys/sysctl.h>, but directly uses the 'real' declaration of
sysctl_add_oid(9).

Fortunately __FreeBSD_version was bumped to 1200019 very soon afterwards, in
r310149, though it was for unrelated changes.  We can use this as a stopgap
fix, to add an extra NULL parameter.

-- 
You are receiving this mail because:
You are the assignee for the bug.