[Bug 208525] databases/mysql57-server: Fix build with libc++ 3.8.0

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208525

--- Comment #2 from Dimitry Andric <dim at FreeBSD.org> ---
(In reply to Mahdi Mokhtari from comment #1)
> Hi, I've checked your patch, i like to ask some points:
> 
> Doesn't it cause errors for other builds (that doesn't use libc++3.8) ? [if
> yes i think there's a solution to apply the patch conditionally :D]

This shouldn't change anything for systems with earlier versions of libc++, or
with libstdc++.

The only reason this issue now pops up with libc++ 3.8 is that they've put a
static assertion in the std::map class, which checks at compile time whether
the value_type was defined correctly.  It turns out a lot of software makes
mistakes in this area. :)


> You can now successfully build both mysql57 server and client after you
> apply this patch ?

Yes, I verified that, both with the old and new libc++.


> I'm okay to approve patch :), if you confirm both.
> if you didn't tried to build (or you're busy and cant try it now), tell me
> and i'll do it ;)

It would be nice if you double-checked on your system(s), to see if it also
works OK for you.  I could have made a mistake... :)

-- 
You are receiving this mail because:
You are the assignee for the bug.