[Bug 198869] USE_GITHUB doesn't set WRKSRC correctly.

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198869

            Bug ID: 198869
           Summary: USE_GITHUB doesn't set WRKSRC correctly.
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Ports Framework
          Assignee: portmgr at FreeBSD.org
          Reporter: amdmi3 at FreeBSD.org
                CC: freebsd-ports-bugs at FreeBSD.org

USE_GITHUB sets WRKSRC incorrectly in some cases. For instance, see
games/freeblocks with removed GH_COMMIT. After `make fetch makesum extract`:

Index: Makefile
===================================================================
--- Makefile    (revision 382055)
+++ Makefile    (working copy)
@@ -14,7 +14,7 @@
 USE_GITHUB=    yes
 GH_ACCOUNT=    dorkster
 GH_TAGNAME=    v${PORTVERSION}
-GH_COMMIT=    3c58e62
+#GH_COMMIT=    3c58e62

 USES=        cmake
 CMAKE_ARGS=    -DDATADIR="${DATADIR_REL}"
Index: distinfo
===================================================================
--- distinfo    (revision 382055)
+++ distinfo    (working copy)
@@ -1,2 +1,2 @@
-SHA256 (freeblocks-0.5.tar.gz) =
0d24a2b61a504e76ea71b95436272353d1e74721438b158a31706dd211866e9c
-SIZE (freeblocks-0.5.tar.gz) = 7914638
+SHA256 (dorkster-freeblocks-0.5-v0.5_GH0.tar.gz) =
8da72ccf7bcba585fcd8b65943f590f51aff06286f3ed920a13c0c90fb392e06
+SIZE (dorkster-freeblocks-0.5-v0.5_GH0.tar.gz) = 7914439

% make -V WRKSRC 
.../games/freeblocks/work/freeblocks-v0.5
% ls work
freeblocks-0.5

As I understand, github removes leading v from the tag name, so we should do
the same.

-- 
You are receiving this mail because:
You are on the CC list for the bug.