[Bug 198736] net-mgmt/smokeping init script fails to check pid correctly

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198736

            Bug ID: 198736
           Summary: net-mgmt/smokeping init script fails to check pid
                    correctly
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: rodrigo at FreeBSD.org
          Reporter: vince at unsane.co.uk
          Assignee: rodrigo at FreeBSD.org
             Flags: maintainer-feedback?(rodrigo at FreeBSD.org)

Created attachment 154574
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=154574&action=edit
patch to the smokeping rc.d init file

The init script for smokeping doesn't pass the the interpreter (perl) to
check_pidfile so will claim smokeping isnt running when it is.
adding $command_interpreter as the 3rd argument to check_pidfile fixes this. I
have attached a patch for this

Also there should probably be a sleep 1 or something in smokeping_stop() as a
restart happens too fast and tries to start it again before it dies but I'm
unsure of best practices for that situation so I havent tried to patch this.

-- 
You are receiving this mail because:
You are the assignee for the bug.