[Bug 196236] graphics/shotwell: Segmentation fault

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196236

John Marino <marino at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marino at FreeBSD.org

--- Comment #10 from John Marino <marino at FreeBSD.org> ---
This doesn't look right to me.

1) the whole point of using USES=compiler: is to avoid having to use OSVERSION.
 you have OSVERSION check before setting USES=compiler

2) You use OSVERSION without checking OPSYS.  This breaks OPSYS=DragonFly.

3) More DragonFly incompatibility -- DragonFly has libgomp in base and does not
have libc++ 

I would say at the very least do something like:

.if ${PORT_OPTIONS:MOPENMP}
. if ${OPSYS} == FreeBSD
[your stuff]
. endif
.endif

that should be fine for dragonfly since it supports gomp in base.

-- 
You are receiving this mail because:
You are the assignee for the bug.