[Bug 196679] [patch] x11-wm/fvwm2: Fix compilation error related to gtk12 and clang

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196679

            Bug ID: 196679
           Summary: [patch] x11-wm/fvwm2: Fix compilation error related to
                    gtk12 and clang
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: cy at FreeBSD.org
          Reporter: CQG00620 at nifty.ne.jp
          Assignee: cy at FreeBSD.org
             Flags: maintainer-feedback?(cy at FreeBSD.org)

Created attachment 151552
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=151552&action=edit
A patch for x11-wm/fvwm2.

The previous version of x11-wm/fvwm2 had IMLIB option [1], and the option was
disabled by default.  If the option was disabled, added "--disable-gtk" to
the CONFIGURE_ARGS variable like this:

| .if ${PORT_OPTIONS:MIMLIB}     
| USE_GNOME+=     imlib          
| .else          
| CONFIGURE_ARGS+=--disable-gtk          
| .endif         

...and the FvwmGtk module was not compiled (it requires GTK) and disabled
in pkg-plist.

But the latest x11-wm/fvwm2 doesn't specify "--disable-gtk" anywhere.
So if x11-toolkits/gtk12 has been installed to the system, the configure script
detects the library automatically and tries to compile FvwmGtk which is not
listed in pkg-plist.

Unfortunately FvwmGtk cannot be compiled with clang and causes a compilation
error.  To fix the problem, add a missing "--disable-gtk" argument to the
CONFIGURE_ARGS variable.

# If we really want to compile FvwmGtk with clang, at least we have to add
# "USE_CSTD=gnu89" to Makefile [2].

[1]
http://svnweb.freebsd.org/ports/head/x11-wm/fvwm2/Makefile?view=log#rev375573
[2]
https://lists.freebsd.org/pipermail/freebsd-ports/2014-December/thread.html#97303

--- Comment #1 from Bugzilla Automation <bugzilla at FreeBSD.org> ---
Auto-assigned to maintainer cy at FreeBSD.org

-- 
You are receiving this mail because:
You are the assignee for the bug.