[Bug 196460] Fix sysutils/flashrom compilation with latest clang version

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196460

            Bug ID: 196460
           Summary: Fix sysutils/flashrom compilation with latest clang
                    version
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: freebsd-ports-bugs at FreeBSD.org
          Reporter: olivier at cochard.me
                CC: nukama+maintainer at gmail.com
             Flags: maintainer-feedback?(nukama+maintainer at gmail.com)
                CC: nukama+maintainer at gmail.com

Created attachment 151261
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=151261&action=edit
patch file for flashrom with latest release of clang

sysutils/flashrom compilation failed with latest clang on these errors:

flashrom.c:1741:6: error: comparison of array 'flashchips' equal to a null
pointer is always false [-Werror,-Wtautological-pointer-compare]
        if (flashchips == NULL || flashchips[0].vendor == NULL) {
            ^~~~~~~~~~    ~~~~
flashrom.c:1750:6: error: comparison of array 'chipset_enables' equal to a null
pointer is always false [-Werror,-Wtautological-pointer-compare]
        if (chipset_enables == NULL) {
            ^~~~~~~~~~~~~~~    ~~~~
flashrom.c:1754:6: error: comparison of array 'board_matches' equal to a null
pointer is always false [-Werror,-Wtautological-pointer-compare]
        if (board_matches == NULL) {
            ^~~~~~~~~~~~~    ~~~~
flashrom.c:1758:6: error: comparison of array 'boards_known' equal to a null
pointer is always false [-Werror,-Wtautological-pointer-compare]
        if (boards_known == NULL) {
            ^~~~~~~~~~~~    ~~~~
flashrom.c:1762:6: error: comparison of array 'laptops_known' equal to a null
pointer is always false [-Werror,-Wtautological-pointer-compare]
        if (laptops_known == NULL) {
            ^~~~~~~~~~~~~    ~~~~
5 errors generated.
Makefile:656: recipe for target 'flashrom.o' failed


I've applied the patch found here for fixing this error:
https://code.google.com/p/chromium/issues/detail?id=347749

--- Comment #1 from Bugzilla Automation <bugzilla at FreeBSD.org> ---
Maintainer CC'd

-- 
You are receiving this mail because:
You are the assignee for the bug.