[Bug 197786] [PATCH] math/pspp: Bump PORTREVISION, take maintainership

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sat Feb 28 23:58:51 UTC 2015


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197786

Jan Beich <jbeich at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cpm at fbsd.es
 Attachment #153632|                            |maintainer-approval?(cpm at fb
              Flags|                            |sd.es)

--- Comment #5 from Jan Beich <jbeich at FreeBSD.org> ---
Created attachment 153632
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=153632&action=edit
alternative version

Maybe also install Emacs mode for syntax highlightling and facilitating
indentation/commenting in .sps files.

>+OPTIONS_DEFAULT=	DOCS NLS

Already there, see Mk/bsd.options.mk.

>+post-install:
>+.for f in libpspp libpspp-core
>+	${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/${PORTNAME}/${f}-${PORTVERSION}.so
>+.endfor
>+
>+.if ${PORT_OPTIONS:MGUI}
>+	${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/glade3/modules/libglade-psppire.so.0.0.0

Why? install-strip is enough or you can simplify the following

  GUI_INSTALL_TARGET=    install-strip ...
  GUI_INSTALL_TARGET_OFF=    install-strip

into

  INSTALL_TARGET=    install-strip

  GUI_INSTALL_TARGET=    ...

> +DOCS=	ABOUT-NLS AUTHORS COPYING ChangeLog INSTALL NEWS ONEWS \
> +	README THANKS TODO
> +
[...]
> +	${MKDIR} ${STAGEDIR}${DOCSDIR}
> +	cd ${WRKSRC} && ${INSTALL_DATA} ${DOCS} ${STAGEDIR}${DOCSDIR}
[...]
> +%%PORTDOCS%%%%DOCSDIR%%/ABOUT-NLS
> +%%PORTDOCS%%%%DOCSDIR%%/AUTHORS
> +%%PORTDOCS%%%%DOCSDIR%%/COPYING
> +%%PORTDOCS%%%%DOCSDIR%%/ChangeLog
> +%%PORTDOCS%%%%DOCSDIR%%/INSTALL
> +%%PORTDOCS%%%%DOCSDIR%%/NEWS
> +%%PORTDOCS%%%%DOCSDIR%%/ONEWS
> +%%PORTDOCS%%%%DOCSDIR%%/README
> +%%PORTDOCS%%%%DOCSDIR%%/THANKS
> +%%PORTDOCS%%%%DOCSDIR%%/TODO

Unless you want to keep everything in one place at the expense of
listing installed files several times the above can be simplified to:

  PORTDOCS=    AUTHORS ChangeLog NEWS ONEWS README THANKS TODO

          (cd ${WRKSRC} && ${COPYTREE_SHARE} \
                  "${PORTDOCS}" ${STAGEDIR}${DOCSDIR})

ABOUT-NLS is generic help-file from gettext.

COPYING is redundant because LICENSE=GPLv3 already installs
/usr/ports/Templates/Licenses/GPLv3.

INSTALL is pointless for people using the FreeBSD port/package and
not trying to figure out how to compile pspp themselves.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list