[Bug 197975] textproc/mgdiff take MAINTAINERship

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197975

--- Comment #4 from Chris Hutchinson <portmaster at bsdforge.com> ---
(In reply to Jan Beich from comment #2)
> Comment on attachment 153408 [details]
> svn diff for textproc/mgdiff
> 
> > USES=		imake motif
> > USE_XORG=	ice sm x11 xext xmu xp xt
> >-SUB_FILES=	pkg-message
> > 
> >+DESKTOP_ENTRIES=	"mgdiff" "GUI front end to the UNIX diff command" \
> >+			"mgDIFF-48x48" \
> >+			"mgdiff" "GNOME;GTK;Motif;Development;System;" \
> 
> Why the app is listed in GNOME and GTK categories but has no such
> dependencies?
It's just a standard template I use. No harm comes from listing them.
No warnings will be emitted either.
> 
> >+WWW: http://BSDforge.com/projects/textproc/mgdiff/
> 
> WWW doesn't match MASTER_SITES. Did you take upstream maintainership as well?
Upstream hasn't, to the best of my knowledge, *ever* provided a WWW. As a
WWW wasn't provided in src, or the port, I felt others would benefit
from having one. As to take upstream maintenance; I'm waiting to see
if the original author expresses any objection (I've contacted him).
> 
> > post-install:
> >-	@${MKDIR} ${STAGEDIR}${PREFIX}/lib/X11/mgdiff
> >-	${INSTALL_DATA} ${WRKSRC}/mgdiff.x[bp]m ${STAGEDIR}${PREFIX}/lib/X11/mgdiff
> >+	@${MKDIR} ${STAGEDIR}${PREFIX}/share/pixmaps
> >+	${CP} ${FILESDIR}/mgDIFF-48x48.xpm ${STAGEDIR}${PREFIX}/share/pixmaps/mgDIFF-48x48.xpm
> 
> Why different case: mgDIFF vs. mgdiff?
Cause it was easier for me to [visually] differentiate it.
> share/pixmaps icons aren't themed, so
> Icon=mgdiff-48x48 in .desktop file won't match other colorless variants.
> Here's a quick test for Gtk behavior via attachment 153255 [details]
> 
>   $ icon-lookup
>   usage: icon-lookup icon_theme icon_name size flags
> 
>   $ icon-lookup test mgdiff 0 0
>   /usr/local/share/pixmaps/mgdiff.xpm
>   $ icon-lookup test mgdiff 48 0
>   /usr/local/share/pixmaps/mgdiff.xpm
> 
>   $ icon-lookup test mgdiff-48x48 0 0
>   /usr/local/share/pixmaps/mgdiff-48x48.xpm
>   $ icon-lookup test mgdiff-48x48 48 0
>   /usr/local/share/pixmaps/mgdiff-48x48.xpm
Thanks!
> 
> >+	${INSTALL_DATA} ${WRKSRC}/mgdiff.x[bp]m ${STAGEDIR}${PREFIX}/share/pixmaps
> 
> Note, XBM format isn't supported by Icon Theme spec (v0.11). And mgdiff.xbm
> is already embedded in the binary.
> 
>   $ fgrep -r .xbm .
>   ./Makefile.ini:MISC     = Makefile Imakefile mgdiff.xbm Mgdiff.ad
>   ./Makefile.ini:mgdiff.o : mgdiff.c mgdiff.h externs.h patchlevel.h
> mgdiff.xbm
>   ./mgdiff.c:#include "mgdiff.xbm"
I intended to incorporate the new colored one globally. But need to add
more applications to the box I'm developing on, in order to create the
SVG format I intend to use. The box I develop on is slated for an
update [FreeBSD] so decided to wait until then, before adding the
additional applications. The one I provided, will suffice during the
[short] interim.

Thanks for all your attention to this, Jan Beich.

--Chris

-- 
You are receiving this mail because:
You are the assignee for the bug.