[Bug 197975] textproc/mgdiff take MAINTAINERship

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197975

--- Comment #2 from Jan Beich <jbeich at FreeBSD.org> ---
Comment on attachment 153408
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=153408
svn diff for textproc/mgdiff

> USES=		imake motif
> USE_XORG=	ice sm x11 xext xmu xp xt
>-SUB_FILES=	pkg-message
> 
>+DESKTOP_ENTRIES=	"mgdiff" "GUI front end to the UNIX diff command" \
>+			"mgDIFF-48x48" \
>+			"mgdiff" "GNOME;GTK;Motif;Development;System;" \

Why the app is listed in GNOME and GTK categories but has no such dependencies?

>+WWW: http://BSDforge.com/projects/textproc/mgdiff/

WWW doesn't match MASTER_SITES. Did you take upstream maintainership as well?

> post-install:
>-	@${MKDIR} ${STAGEDIR}${PREFIX}/lib/X11/mgdiff
>-	${INSTALL_DATA} ${WRKSRC}/mgdiff.x[bp]m ${STAGEDIR}${PREFIX}/lib/X11/mgdiff
>+	@${MKDIR} ${STAGEDIR}${PREFIX}/share/pixmaps
>+	${CP} ${FILESDIR}/mgDIFF-48x48.xpm ${STAGEDIR}${PREFIX}/share/pixmaps/mgDIFF-48x48.xpm

Why different case: mgDIFF vs. mgdiff? share/pixmaps icons aren't themed, so
Icon=mgdiff-48x48 in .desktop file won't match other colorless variants. Here's
a quick test for Gtk behavior via attachment 153255

  $ icon-lookup
  usage: icon-lookup icon_theme icon_name size flags

  $ icon-lookup test mgdiff 0 0
  /usr/local/share/pixmaps/mgdiff.xpm
  $ icon-lookup test mgdiff 48 0
  /usr/local/share/pixmaps/mgdiff.xpm

  $ icon-lookup test mgdiff-48x48 0 0
  /usr/local/share/pixmaps/mgdiff-48x48.xpm
  $ icon-lookup test mgdiff-48x48 48 0
  /usr/local/share/pixmaps/mgdiff-48x48.xpm

>+	${INSTALL_DATA} ${WRKSRC}/mgdiff.x[bp]m ${STAGEDIR}${PREFIX}/share/pixmaps

Note, XBM format isn't supported by Icon Theme spec (v0.11). And mgdiff.xbm is
already embedded in the binary.

  $ fgrep -r .xbm .
  ./Makefile.ini:MISC     = Makefile Imakefile mgdiff.xbm Mgdiff.ad
  ./Makefile.ini:mgdiff.o : mgdiff.c mgdiff.h externs.h patchlevel.h mgdiff.xbm
  ./mgdiff.c:#include "mgdiff.xbm"

-- 
You are receiving this mail because:
You are the assignee for the bug.