[Bug 197599] devel/librest: does not pass the tests

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197599

--- Comment #6 from cmt at burggraben.net ---
The "oauth" test dumps core like this:

(gdb) bt
#0  0x0000000801931a90 in g_string_append_uri_escaped ()
   from /usr/local/lib/libglib-2.0.so.0
#1  0x0000000800831911 in sign_hmac (proxy=0x80642c0b0, call=0x80923a0b0, 
    oauth_params=0x809148de0) at oauth-proxy-call.c:149
#2  0x0000000800831476 in _prepare (call=0x80923a0b0, error=0x7fffffffd870)
    at oauth-proxy-call.c:292
#3  0x000000080082aee7 in prepare_message (call=0x80923a0b0, 
    error_out=0x7fffffffd970) at rest-proxy-call.c:830

and:
149         g_string_append_uri_escaped (text, url_str, NULL, FALSE);
(gdb) print url_str
$1 = 0x664e580 <error: Cannot access memory at address 0x664e580>

Lo and behold, there was a warning on the assignment to just that url_str:
oauth-proxy-call.c:130:11: warning: incompatible integer to pointer conversion
      assigning to 'const char *' from 'int' [-Wint-conversion]
  url_str = rest_proxy_call_get_url (call);

which explains the garbage address in url_str.
And for real, upstream fixed that bug without realising it's impact:
https://git.gnome.org/browse/librest/commit/?id=b50ace7738ea03817acdad87fb2b338a86018329

-- 
You are receiving this mail because:
You are the assignee for the bug.