[Bug 197750] archivers/unzip: INSTALL_AS_INFOUNZIP confuses users and breaks dependent ports

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197750

            Bug ID: 197750
           Summary: archivers/unzip: INSTALL_AS_INFOUNZIP confuses users
                    and breaks dependent ports
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ehaupt at FreeBSD.org
          Reporter: amdmi3 at FreeBSD.org
             Flags: maintainer-feedback?(ehaupt at FreeBSD.org)
          Assignee: ehaupt at FreeBSD.org

Created attachment 153092
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=153092&action=edit
Patch

I've been investigating openjdk7 build failure for some user, and discovered
that he had INSTALL_AS_INFOUNZIP in his make.conf. Obviously, it made unzip
port not install bin/unzip binary, which broke dependent ports that need unzip.

Now I wonder, what is the purpose of that knob? I see no reason for optional
installation of infounzip binary, so it may be installed unconditionally as a
link to unzip (or vice versa). If the point is in optional installation of
unzip binary, it requires cooperation from ports framework, namely Uses/zip.mk
or bsd.commands.mk, which should tweak unzip dependency.

The way INSTALL_AS_INFOUNZIP is implemented now is broken and if there's no
real reason behind it, I propose to remove it. Patch attached.

--- Comment #1 from Bugzilla Automation <bugzilla at FreeBSD.org> ---
Auto-assigned to maintainer ehaupt at FreeBSD.org

-- 
You are receiving this mail because:
You are the assignee for the bug.