[Bug 197258] [maintainer update] audio/id3mtag: update to 0.79

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Mon Feb 2 18:43:39 UTC 2015


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197258

Dmitry Marakasov <amdmi3 at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|freebsd-ports-bugs at FreeBSD. |amdmi3 at FreeBSD.org
                   |org                         |
         Resolution|---                         |FIXED
                 CC|                            |amdmi3 at FreeBSD.org
             Status|New                         |Closed

--- Comment #2 from Dmitry Marakasov <amdmi3 at FreeBSD.org> ---
Committed with minor change (added LICENSE_FILE).

Since you're the author, I suggest to fix the makefile to not override flags
set in environment. This will make building with pre-set environment and from
packaging systems easier. In particular, with FreeBSD ports it'll allow to drop
MAKE_ARGS.

---
-CC      = cc
-CXX     = c++
-CFLAGS  = $(WARNINGS:%=-W%) -pedantic -g -Os
-CXXFLAGS = $(CFLAGS) -fno-rtti
-LDFLAGS  =
+CC      ?= cc
+CXX     ?= c++
+CFLAGS  += $(WARNINGS:%=-W%) -pedantic -g -Os
+CXXFLAGS += $(WARNINGS:%=-W%) -pedantic -g -Os -fno-rtti
+LDFLAGS  +=
---

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list