[Bug 197241] [PATCH] sysutils/lsof fix build on systems without /etc/make.conf

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sun Feb 1 13:31:50 UTC 2015


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197241

            Bug ID: 197241
           Summary: [PATCH] sysutils/lsof fix build on systems without
                    /etc/make.conf
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: freebsd-ports-bugs at FreeBSD.org
          Reporter: riggs at FreeBSD.org
                CC: ler at lerctr.org
                CC: ler at lerctr.org
             Flags: maintainer-feedback?(ler at lerctr.org)

Created attachment 152436
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=152436&action=edit
Patch to fix build on systems without /etc/make.conf

Terry Kennedy <terry at tmk.com> noticed that on plain vanilla installations of
FreeBSD lsof does not build due to picking up CFLAGS incorrectly.

We tracked this down to a bug in lsof's configure script checking for the
existence of make.conf and then deriving CFLAGS based on the result.
It turns out that it does not do anything with make.conf's content, but its
absence causes the configure script to select CFLAGS erroneously.
The attached micro-patch ensures that the same algorithm is always used to
select CFLAGS, independently of make.conf's existence on the target machine.

Tested on 8.4, 9.3 (i386) and 10.1 (amd64, armv6).

@Maintainer: Do you approve?

--- Comment #1 from Bugzilla Automation <bugzilla at FreeBSD.org> ---
Maintainer CC'd

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list