[Bug 202704] [PATCH] sysutils/puppet update puppetmaster rc.d script to use `manifest` instead of `manifestdir`/site.pp

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202704

            Bug ID: 202704
           Summary: [PATCH] sysutils/puppet update puppetmaster rc.d
                    script to use `manifest` instead of
                    `manifestdir`/site.pp
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: swills at FreeBSD.org
          Reporter: yesthanks at lemonia.org
          Keywords: patch
             Flags: maintainer-feedback?(swills at FreeBSD.org)
          Assignee: swills at FreeBSD.org

Created attachment 160431
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=160431&action=edit
patch for puppetmaster rc.d script

The `rc.d/puppetmaster` script sanity checks Puppet configuration before
starting using `puppet validate `${puppetmaster_manifestdir}/site.pp`

Directory-based environments [1] provide a level of indirection for the
location of the default site manifest through `environment.conf`. This allows
the administrator to set a new location for `site.pp` with the `manifest`
directive, but it does not allow for a new `manifestdir` [2][3].

This means it's possible to have `puppet config` report a bogus answer to
`print manifestdir` whilst reporting the correct answer to `print manifest`.
This prevents the Puppetmaster from starting because it can not validate an
absent `/usr/local/etc/puppet/manifests/site.pp`.

This small patch makes the script discover and validate the site manifest
wherever it has been configured to be.

[1] https://docs.puppetlabs.com/puppet/3.8/reference/environments_creating.html
[2]
https://docs.puppetlabs.com/puppet/3.8/reference/config_file_environment.html#allowed-settings
[3] My own motivation is to point Puppet to a Git repository elsewhere and
leave /usr/local/etc/puppet (almost) alone

-- 
You are receiving this mail because:
You are the assignee for the bug.