[Bug 193615] New: [maintainer] update port: www/libevhtp 8.4-RELEASE breakage

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193615

            Bug ID: 193615
           Summary: [maintainer] update port: www/libevhtp  8.4-RELEASE
                    breakage
           Product: Ports Tree
           Version: Latest
          Hardware: Any
                OS: Any
            Status: Needs Triage
          Severity: Affects Only Me
          Priority: ---
         Component: Infrastructure
          Assignee: freebsd-ports-bugs at FreeBSD.org
          Reporter: yan_jingfeng at yahoo.com

Created attachment 147279
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=147279&action=edit
SVN diff same 146878 content, but load from file, not paste

Last commit intends to add sys/types.h for FreeBSD 8.4. However, the trick is
over-played. 

"#ifdef SO_ACCEPT... " location of the patch file has problem, which causes the
sys/types is not included finally. 

In the original test patch on 8.4, #ifdef SO_ACCEPTFILTER is placed at the end
of #include section.  This helps to pass the test because SO_ACCEPTFILTER is
defined in sys/socket.h and the socket.h is included before. In such case,
sys/types.h is included.  When committing and generate the diff for SVN, I
adjust its location. 

When #ifdef SO_ACCEPTFILTER listed before socket.h, this test return false. 
Then, the types.h will not included. 

Overall, it is not necessary to use this test, and sys/types.h can be include
more blindly.

-- 
You are receiving this mail because:
You are the assignee for the bug.