[Bug 193542] [MAINTAINER] x11-fonts/alef: Bump PORTREVISION

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193542

--- Comment #4 from Carlos Jacobo Puga Medina <cpm at fbsd.es> ---
(In reply to Jason E. Hale from comment #2)
> - Comment should not start with indefinite article "A"
> - Installation commands should not be muted (mkdirs OK)
> - Installation of DOCS should not be conditional.  Staging will take care of
> it automatically
> - To install the DOCS without the for loop, the easiest way is:
>   ${INSTALL_DATA} ${PORTDOCS:S|^|${WRKDIR}/|} ${STAGEDIR}${DOCSDIR}
> - This port has a BUILD_DEPENDS on fc-cache(1), which it doesn't even use
> - It should be running mkfontdir(1) and mkfontscale(1) in the directory
> where the fonts are.  Of course, the generated files need added to pkg-plist.
> - It would be better if NO_WRKSUBDIR were set, then you wouldn't have to
> redefine WRKSRC and it would eliminate the first two lines of the
> post-extract target.
> - Since LICENSE_FILE is being added, it should be removed from PORTDOCS so
> that it isn't installed twice

Done! Thank you for the triage.

-- 
You are receiving this mail because:
You are the assignee for the bug.