[Bug 181301] [NEW PORT] net/kamailio: Very fast and configurable open source SIP proxy

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=181301

--- Comment #11 from John Marino <marino at FreeBSD.org> ---
(In reply to olivermahmoudi from comment #10)

> 5) XPLIST_SUB+=	MYSQL=""
> X.else
> XPLIST_SUB+=	MYSQL="@comment "
> 
> This is ancient use of options, use the new OPTIONS_SUB please (review
> porters handbook on OPTIONS)
> 
> The program's configure stage is non standard and options are passed on a
> pre-build stage to prepare the built. Checked back on this issued with the
> ports mailing list. Their feedback was that it is still OK to keep it that 
> way since the new way of setting up the options won't solve my special
> scenario here.

Well, except OPTIONS_SUB affects PLIST_SUB and not configure arguments.  I was
objecting to your (ancient) brute force definitions of "" and "@comment " which
is unnecessary with OPTIONS_SUB

-- 
You are receiving this mail because:
You are the assignee for the bug.