[Bug 193294] [maintainer] graphics/repng2jpeg better conformity upgrade version to ????

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193294

--- Comment #5 from C Hutchinson <portmaster at bsdforge.com> ---
(In reply to John Marino from comment #2)
> A)
> 
> -COMMENT=	Tool to recompress JPEG/PNG/GIF
> +COMMENT=	A small tool to recompress JPEG, PNG, and GIF images
> 
> That's not a good change.
> You can't start a comment with "A", "The", "An", or the name of the port.
> I don't know why you are changing this line at all actually, but at lease
> change "A small tool" to "Tool" (who cares if it's small?)
> 
> B)
> Since you are controlling the source, please increment the version instead
> of rerolling the source tarball.  That's a huge faux-pas.  We are supposed
> to immediately request to upstreams that re-roll tarballs to stop it and
> don't do it anymore.
> 
> This isn't a "if you can" request.  if you want to change the source, either
> use patches or roll a new tarball with a new version.
> 
> If you already published the tarball, you also just broke the port, by the
> way.  It won't fetch anymore.

Nope. No faux-pas here. Well, not really. In this case, there was a subtle
re-naming change; from: PORTNAME_VERSION, to: PORTNAME-VERSION. Underscore,
to hyphen. No possible fetch(1) issue(s) either. I left the previous
file as-was, where-was. I thought of all that, already. :)

Thanks, John.

--Chris

-- 
You are receiving this mail because:
You are the assignee for the bug.